feat(icon): File and folder icons for Postgraphile#3393
feat(icon): File and folder icons for Postgraphile#3393Deckstar wants to merge 2 commits intomaterial-extensions:mainfrom
Conversation
PreviewThank you for creating a pull request. This preview shows you how your icons will look on the different themes: Check how your icons fit in a 16x16 grid with our Pixel Perfect Checker by following this link. You can find more information on how to contribute in the contribution guidelines. |
Deckstar
changed the title
|
Hey @PKief sorry for the direct tag. Just wondering if there's anything specific I need to do to get this reviewed? 🙂 |
|
@Deckstar Hi. Sorry for the late reply. Your proposed icons have too many shapes and doesn't follow our grid system: You can find more information here: |
|
You can also try to use our new tool where you can actually see how VS Code will render your icon in a 16x16 pixel grid: This is how it will look like: When we keep the shapes more simple and align the edges with the grid it will look better. Now's, the question how to do this. Not sure tbh, not every icon can fit directly into our theme. Usually we try to abstract some shapes to make it look similar to the original icon but following the grid lines, or we abstract even more by using some different icon (e.g. different elephant motive) which also fits and looks better as a file icons. Here it comes to the creativity part and the exploration part. That's why I can't give you a direct solution to this. |
2 participants
Description
TLDR:
This pull request adds file and folder icons for common Postgraphile files and folders.
Context: What is PostGraphile?
Postgraphile is a library for quickly generating GraphQL APIs based on a PostgreSQL database. It currently has 12.9k GitHub stars and has just entered beta testing for its long-awaited v5. It's part of the overall Graphile project, which is a set of tools for working with PostgreSQL to create performant GraphQL APIs.
Contribution details
As part of this PR, I have:
I also confirm that I have run
bunx lint-stagedin the repo and that all linting stages have passed.Thank you very much for your time and this wonderful library! And I hope my new icons can be accepted 🙂
Contribution Guidelines